Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16 #400

Merged

Conversation

iamniting
Copy link
Member

This is an manual cherry-pick of #399

In older clusters, upgrading the odf channel from 4.15 to 4.16 tries to
bring the rook-operator, leading to conflicts with ocs-operator 4.15,
which already contains all Rook components in its 4.15 CSV. This
conflict results in upgrade failures.

To address this issue, the Rook dependency is removed from the
odf-operator and added to the ocs-operator. This solution ensures a
smooth upgrade process, as changing the ocs-operator channel will now
bring Rook along with ocs-operator 4.16 without encountering conflicts.

This commit should be reverted in 4.17 as 4.16 will feature different
CSVs. In 4.17, reintroducing Rook as a dependency in odf should
facilitate smooth installations and upgrades.

Signed-off-by: Nitin Goyal <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@iamniting: This pull request references Bugzilla bug 2275456, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: vavuthu.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@iamniting: This pull request references Bugzilla bug 2275456, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting changed the base branch from main to release-4.16 April 18, 2024 10:18
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@iamniting: This pull request references Bugzilla bug 2275456, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: vavuthu.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@iamniting: This pull request references Bugzilla bug 2275456, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/override ci/prow/odf-operator-e2e-aws

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/odf-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 46a0302 into red-hat-storage:release-4.16 Apr 18, 2024
28 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@iamniting: All pull requests linked via external trackers have merged:

Bugzilla bug 2275456 has been moved to the MODIFIED state.

In response to this:

Bug 2275456:[release-4.16] bundle: remove rook as a dependency to allow upgrades from 4.15 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants